[SQLLab] Fix updating the database state. #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Thanks for fixing this Bogdan! |
ascott
reviewed
Sep 30, 2016
| @@ -11,7 +14,7 @@ class DatabaseSelect extends React.Component { | |||
| databaseId: null, | |||
| }; | |||
| } | |||
| componentWillMount() { | |||
| componentDidMount() { | |||
There was a problem hiding this comment.
componentDidMount is usually used for code that requires that the dom has been rendered, while componentWillMount gets called right before the component is rendered. in this case, you're right, we can use either.
|
LGTM |
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1220
Database changes were not propagated to the redux state, it caused client inability to show the run query button for the activated dbs and also to display newly added databases.
In addition, looks like
componentDidMountis sufficient and may be better thancomponentWillMountas the latter is supposed to be synchronous and called on the server:http://stackoverflow.com/questions/29899116/what-is-the-difference-between-componentwillmount-and-componentdidmount-in-react
Reviewers: