Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uneven list header padding (#12029) #12412

Merged
merged 1 commit into from Jan 13, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Adjust list header padding.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-01-11 at 11 58 16 AM

Screen Shot 2021-01-11 at 2 21 52 PM

Closes #12029

@junlincc

TEST PLAN

1 - Go to any major list (charts, dashboards, databases, etc)
2 - Check header padding

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Jan 11, 2021

Codecov Report

Merging #12412 (ee22c4a) into master (078a8a1) will decrease coverage by 4.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12412      +/-   ##
==========================================
- Coverage   66.81%   62.76%   -4.05%     
==========================================
  Files        1015     1015              
  Lines       49544    49530      -14     
  Branches     5080     5080              
==========================================
- Hits        33102    31088    -2014     
- Misses      16312    18233    +1921     
- Partials      130      209      +79     
Flag Coverage Δ
cypress ?
javascript 60.75% <ø> (ø)
python 64.08% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/components/dataViewCommon/TableCollection.tsx 100.00% <ø> (ø)
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/dashboard/containers/Dashboard.jsx 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/filters/components/Select/types.ts 0.00% <0.00%> (-100.00%) ⬇️
...t-frontend/src/dashboard/containers/SliceAdder.jsx 0.00% <0.00%> (-100.00%) ⬇️
...t-frontend/src/explore/reducers/getInitialState.js 0.00% <0.00%> (-100.00%) ⬇️
... and 195 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 078a8a1...3eccbe3. Read the comment docs.

@adam-stasiak
Copy link
Contributor

tested - No issues found

@junlincc junlincc self-requested a review January 12, 2021 18:51
Copy link
Member

@junlincc junlincc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, perfect!
After:
Screen Shot 2021-01-12 at 10 49 38 AM

Before:
Screen Shot 2021-01-12 at 10 50 14 AM

@nytai please take a look since we touched your area.

NOTE⚠️:

  • This is only Product and QA approval with NO code reviews
  • This approval indicates that all UI changes meet product requirement, no noticeable regression is introduced
  • This approval indicates this PR is ready for code reviews

@rusackas
Copy link
Member

Code looks good to me. Tempted to do the usual nag about gridUnit, but I don't like fractional gridUnits, so I'll let the 2px go :)

I'd merge this, but would love to have @nytai's nod of approval first :D

@rusackas rusackas merged commit 551a3e4 into apache:master Jan 13, 2021
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[listview]: uneven top and bottom header padding
7 participants