Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new Slack dashboard #12415

Merged
merged 3 commits into from Jan 12, 2021
Merged

Conversation

betodealmeida
Copy link
Member

SUMMARY

New dashboard from @srinify showing Slack community.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot_2021-01-11 Slack Dashboard

TEST PLAN

Ran superset load-examples and tested the new dashboard.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Jan 11, 2021

Codecov Report

Merging #12415 (db8a10f) into master (6bee3a0) will decrease coverage by 2.32%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12415      +/-   ##
==========================================
- Coverage   66.33%   64.00%   -2.33%     
==========================================
  Files        1014      485     -529     
  Lines       49528    29899   -19629     
  Branches     5074        0    -5074     
==========================================
- Hits        32854    19138   -13716     
+ Misses      16538    10761    -5777     
+ Partials      136        0     -136     
Flag Coverage Δ
cypress ?
javascript ?
python 64.00% <100.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/datasets/commands/importers/v1/utils.py 55.55% <100.00%> (ø)
superset/examples/birth_names.py 73.19% <0.00%> (-25.65%) ⬇️
superset/db_engine_specs/mysql.py 79.59% <0.00%> (-12.25%) ⬇️
superset/common/query_context.py 82.51% <0.00%> (-3.59%) ⬇️
superset/db_engine_specs/presto.py 81.38% <0.00%> (-1.95%) ⬇️
superset/extensions.py 93.15% <0.00%> (-1.37%) ⬇️
superset/sql_lab.py 79.43% <0.00%> (-0.94%) ⬇️
superset/connectors/sqla/models.py 90.58% <0.00%> (-0.92%) ⬇️
superset/models/core.py 88.04% <0.00%> (-0.82%) ⬇️
superset/views/core.py 74.92% <0.00%> (-0.46%) ⬇️
... and 533 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bee3a0...db8a10f. Read the comment docs.

@betodealmeida betodealmeida merged commit 8f83afc into apache:master Jan 12, 2021
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Jan 14, 2021
* feat: new Slack dashboard

* Add ASL license

* Fix test
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XXL 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants