chore: apply capitalization guidelines - iteration 5 (#12343) #12451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please specify all your changes in this PR, include screenshot and test plan, also for all your future PRs. @michael-s-molina 🙏 |
Codecov Report
@@ Coverage Diff @@
## master #12451 +/- ##
==========================================
+ Coverage 64.55% 66.65% +2.10%
==========================================
Files 1018 1018
Lines 49787 49793 +6
Branches 4971 4877 -94
==========================================
+ Hits 32141 33192 +1051
+ Misses 17468 16478 -990
+ Partials 178 123 -55
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
michael-s-molina
force-pushed
the
apply-capitalization-guidelines-5
branch
from
8b036a7
to
90695d4
Compare
|
looks good to me |
mihir174
reviewed
Jan 13, 2021
superset-frontend/src/explore/components/ExploreViewContainer.jsx
Outdated
Show resolved
Hide resolved
|
Other than "Open Datasource tab" all looks good! Thanks for doing this 🙏 |
rusackas
approved these changes
Jan 13, 2021
michael-s-molina
force-pushed
the
apply-capitalization-guidelines-5
branch
2 times, most recently
from
c8c7f29
to
25d428b
Compare
michael-s-molina
force-pushed
the
apply-capitalization-guidelines-5
branch
from
25d428b
to
f2f012f
Compare
villebro
pushed a commit
that referenced
this pull request
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Apply capitalization guidelines defined in #12343.
@junlincc
TEST PLAN
Check if modified texts are following capitalization guidelines.
ADDITIONAL INFORMATION