Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply capitalization guidelines - iteration 8 (#12343) #12454

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Apply capitalization guidelines defined in #12343.

@junlincc

TEST PLAN

Check if modified texts are following capitalization guidelines.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Jan 12, 2021

Codecov Report

Merging #12454 (79e117a) into master (078a8a1) will decrease coverage by 2.67%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12454      +/-   ##
==========================================
- Coverage   66.81%   64.14%   -2.68%     
==========================================
  Files        1015      486     -529     
  Lines       49544    29940   -19604     
  Branches     5080        0    -5080     
==========================================
- Hits        33102    19204   -13898     
+ Misses      16312    10736    -5576     
+ Partials      130        0     -130     
Flag Coverage Δ
cypress ?
javascript ?
python 64.14% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/databases/schemas.py 99.45% <0.00%> (-0.55%) ⬇️
superset/commands/importers/v1/utils.py 86.04% <0.00%> (-0.07%) ⬇️
superset/css_templates/api.py 95.74% <0.00%> (ø)
superset/annotation_layers/api.py 83.19% <0.00%> (ø)
superset/datasets/commands/importers/v1/utils.py 55.55% <0.00%> (ø)
superset-frontend/src/components/FaveStar.tsx
...tend/src/explore/components/DisplayQueryButton.jsx
.../src/dashboard/components/gridComponents/Chart.jsx
...set-frontend/src/views/CRUD/welcome/ChartTable.tsx
superset-frontend/src/components/Button/index.tsx
... and 513 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 078a8a1...79e117a. Read the comment docs.

@junlincc junlincc added hold! On hold v1.0.1 and removed hold! On hold labels Jan 12, 2021
@adam-stasiak
Copy link
Contributor

I see error in one test which can be triggered by this change.
Could you take care of this failing test?
AssertionError: Timed out retrying: Expected to find content: 'Add annotation layer' but never did.

Copy link

@Steejay Steejay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a capitalization edit.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the eagle eyes @Steejay! Once CSS is fixed, this looks good to go.

@rusackas rusackas merged commit 217034e into apache:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants