New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: apply capitalization guidelines - iteration 8 (#12343) #12454
chore: apply capitalization guidelines - iteration 8 (#12343) #12454
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12454 +/- ##
==========================================
- Coverage 66.81% 64.14% -2.68%
==========================================
Files 1015 486 -529
Lines 49544 29940 -19604
Branches 5080 0 -5080
==========================================
- Hits 33102 19204 -13898
+ Misses 16312 10736 -5576
+ Partials 130 0 -130
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I see error in one test which can be triggered by this change. |
c531c66
to
e22b7da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a capitalization edit.
superset-frontend/src/views/CRUD/csstemplates/CssTemplatesList.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the eagle eyes @Steejay! Once CSS
is fixed, this looks good to go.
e22b7da
to
a7a365d
Compare
a7a365d
to
79e117a
Compare
SUMMARY
Apply capitalization guidelines defined in #12343.
@junlincc
TEST PLAN
Check if modified texts are following capitalization guidelines.
ADDITIONAL INFORMATION