Change status color in tab to match with success #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ascott
reviewed
Oct 5, 2016
| @@ -123,7 +123,7 @@ div.Workspace { | |||
| color: black; | |||
| } | |||
| .success { | |||
| background-color: green; | |||
| background-color: #4AC15F; | |||
There was a problem hiding this comment.
we should use the bootstrap variable here in case we decide to change the success color: @brand-success
|
one small comment about using the color variable, otherwise LGTM |
|
let's ship this as-is and resolve the issue with less variables in the future. thanks for adding an issue! 🚢 |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1030
A small change in css, make status dot in sqllab the same color as our 'brand-success' color in stylesheet.
Before:
After:
Same color as:
@ascott