Refactor the explore view #1252
Conversation
| if not self.datasource_access(viz_obj.datasource): | ||
| return Response( | ||
| json.dumps( | ||
| {'error': "You don't have access to this datasource"}), |
mistercrunch
force-pushed
the
refact_explore2
branch
5 times, most recently
from
53be27a
to
31a6f24
Compare
mistercrunch
force-pushed
the
refact_explore2
branch
from
31a6f24
to
7d24bca
Compare
| @@ -1598,7 +1603,11 @@ def sqllab_viz(self): | |||
| data = json.loads(request.args.get('data')) | |||
| table_name = data.get('datasourceName') | |||
| viz_type = data.get('chartType') | |||
| table = db.session.query(models.SqlaTable).filter_by(table_name=table_name).first() | |||
| table = ( | |||
There was a problem hiding this comment.
should we add a schema here to the filter?
There was a problem hiding this comment.
risk of collisions in the context of unit tests is close to zero
There was a problem hiding this comment.
this code belongs to the views.py @mistercrunch
There was a problem hiding this comment.
oh right, I was just linting here, but we should tackle this
| href = Href( | ||
| '/caravel/explore/{self.datasource.type}/' | ||
| base_endpoint + '{self.datasource.type}/' |
There was a problem hiding this comment.
s/
base_endpoint + '{self.datasource.type}/{self.datasource.id}/'.format(**locals()))
/
'{base_endpoint}/{self.datasource.type}/{self.datasource.id}/'.format(**locals())) ?
| druid_ds = db.session.query(DruidDatasource).filter_by( | ||
| datasource_name="test_click").first() | ||
| col_names = set([c.column_name for c in druid_ds.columns]) | ||
| assert {"affiliate_id", "campaign", "first_seen"} == col_names |
There was a problem hiding this comment.
s/assert/self.AssertEquals - for better error logging
There was a problem hiding this comment.
let's do a blanket PR to replace all for this later
|
Great PR, 🚢 |
| @@ -5,4 +5,5 @@ export CARAVEL_CONFIG=tests.caravel_test_config | |||
| set -e | |||
| caravel/bin/caravel version -v | |||
| export SOLO_TEST=1 | |||
| nosetests tests.core_tests:CoreTests.test_public_user_dashboard_access | |||
| #nosetests tests.core_tests:CoreTests.test_slice_endpoint | |||
There was a problem hiding this comment.
Oh this is just a little helper file to run a specific tests without re-running all the prep work (loading examples, init, ...). typically would just point it to whatever I'm iterating on at the time. I'll change it to receive an argument in the future.
mistercrunch
added
🏷️ bot
No description provided.