fix: return appropriate response when payload has error

[zhaoyongjie]

SUMMARY

Raise an unexpected exception when an empty query in the results panel

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

after

TEST PLAN

Tested in my local environment

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[codecov-io]

Codecov Report

Merging #12575 (0f243c6) into master (f24d3cb) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #12575      +/-   ##
==========================================
- Coverage   66.75%   66.75%   -0.01%     
==========================================
  Files        1015     1015              
  Lines       49633    49634       +1     
  Branches     4839     4839              
==========================================
- Hits        33133    33131       -2     
- Misses      16377    16380       +3     
  Partials      123      123              

Flag	Coverage Δ
cypress	50.98% <100.00%> (ø)
javascript	60.74% <100.00%> (ø)
python	63.95% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...tend/src/dashboard/components/DashboardBuilder.jsx	86.41% <100.00%> (ø)
superset/dashboards/filters.py	96.96% <100.00%> (-0.09%)	⬇️
superset/views/base.py	75.41% <100.00%> (+0.20%)	⬆️
superset/db_engine_specs/presto.py	81.38% <0.00%> (-0.65%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f24d3cb...1b7b10d. Read the comment docs.

[villebro]

Did you check if the same should apply to sample requests? https://github.com/apache/superset/blob/master/superset/viz.py#L257-L258

[zhaoyongjie]

@villebro
Because get_samples always contains columns key in query_obj, so get_sample will always return a dataframe.

superset/superset/viz.py

Lines 246 to 258 in 0f243c6

	def get_samples(self) -> List[Dict[str, Any]]:
	query_obj = self.query_obj()
	query_obj.update(
	{
	"groupby": [],
	"metrics": [],
	"orderby": [],
	"row_limit": config["SAMPLES_ROW_LIMIT"],
	"columns": [o.column_name for o in self.datasource.columns],
	}
	)
	df = self.get_df_payload(query_obj)["df"] # leverage caching logic
	return df.to_dict(orient="records")

[villebro]

Ok thanks for the correction @zhaoyongjie !