New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): nested rows and columns with hovered menu #12603
Conversation
…ded margin on top of chart
I have just a design question here: |
Codecov Report
@@ Coverage Diff @@
## master #12603 +/- ##
==========================================
- Coverage 66.76% 58.81% -7.95%
==========================================
Files 1015 959 -56
Lines 49642 46878 -2764
Branches 4970 4353 -617
==========================================
- Hits 33141 27571 -5570
- Misses 16378 19307 +2929
+ Partials 123 0 -123
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Tested manually across safari,chrome,firefox. No issues spotted 🟢 |
During testing I observed that extremely useful would be to have kind of more obvious graphical option to show exactly which area delete operation touches -> I mean I would love to see much bolder line because this blue one is hard to spot. What do you think @junlincc ? |
@mihir174 Mihir, @ktmud and I have been making ad hoc design decisions more than we should for the product. I will leave above question from @adam-stasiak to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, better than before! thanks for the fix!
i wanted to rip the dashboard out lol, the entire drag & drop + move row & column + adjust chart size experience is just not intuitive(horrible🤦🏾♀️). we are piling fixes on a shaky foundation.
@kkucharc i think that the native filter icons should remain in the same place |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and makes sense. I agree with @junlincc that some more fundamental redesign might be needed here, but in the short term this is a really good fix.
…ded margin on top of chart (#12603)
SUMMARY
When we have nested rows and columns in the dashboard the hovered menu is not visible or have not enough space.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
closes #12601
TEST PLAN
or
Create own dashboard and nest a lot of charts and rows.
ADDITIONAL INFORMATION