Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): Edit dataset save button position #12604

Merged
merged 1 commit into from Jan 19, 2021
Merged

fix(explore): Edit dataset save button position #12604

merged 1 commit into from Jan 19, 2021

Conversation

geido
Copy link
Member

@geido geido commented Jan 19, 2021

SUMMARY

Closes #12587

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

104960770-31013180-59d5-11eb-83ef-720f38a760c2

AFTER:
Screen Shot 2021-01-19 at 18 03 04

TEST PLAN

ADDITIONAL INFORMATION

@junlincc junlincc added explore:dataset Related to the dataset of Explore v1.0.1 labels Jan 19, 2021
@codecov-io
Copy link

codecov-io commented Jan 19, 2021

Codecov Report

Merging #12604 (2f3749a) into master (9771b82) will decrease coverage by 4.37%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12604      +/-   ##
==========================================
- Coverage   66.76%   62.38%   -4.38%     
==========================================
  Files        1015     1015              
  Lines       49642    49633       -9     
  Branches     4970     4839     -131     
==========================================
- Hits        33141    30966    -2175     
- Misses      16378    18469    +2091     
- Partials      123      198      +75     
Flag Coverage Δ
cypress ?
javascript 60.74% <100.00%> (ø)
python 63.47% <ø> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-frontend/src/datasource/DatasourceModal.tsx 73.77% <100.00%> (ø)
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/dashboard/containers/Dashboard.jsx 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/filters/components/Select/types.ts 0.00% <0.00%> (-100.00%) ⬇️
...t-frontend/src/dashboard/containers/SliceAdder.jsx 0.00% <0.00%> (-100.00%) ⬇️
...t-frontend/src/explore/reducers/getInitialState.js 0.00% <0.00%> (-100.00%) ⬇️
... and 197 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9771b82...2f3749a. Read the comment docs.

@adam-stasiak
Copy link
Contributor

tested manually 🟢

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit c347ddb into apache:master Jan 19, 2021
villebro pushed a commit that referenced this pull request Jan 25, 2021
@mistercrunch mistercrunch added 🍒 1.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:dataset Related to the dataset of Explore size/S v1.0.1 🍒 1.0.1 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Explore]modal cancel button should come before the save button
8 participants