fix: save tabs when saving the query bug #12607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughhhh
changed the title
betodealmeida
approved these changes
Jan 19, 2021
| }) | ||
| .then(() => { | ||
| dispatch(addSuccessToast(t('Your query was updated'))); | ||
| dispatch(queryEditorSetTitle(query, query.title)); |
There was a problem hiding this comment.
This line is the only difference, right?
There was a problem hiding this comment.
yup, but moved it to the bottom of the page
Codecov Report
@@ Coverage Diff @@
## master #12607 +/- ##
==========================================
- Coverage 66.72% 63.06% -3.67%
==========================================
Files 1014 1015 +1
Lines 49612 50929 +1317
Branches 4839 4839
==========================================
- Hits 33106 32117 -989
- Misses 16383 18614 +2231
- Partials 123 198 +75
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
3 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix small bug with updating the query tab name on query save. This bug only appears specifically when SQLLAB_BACKEND_PERSISTENCE is True.
Reference for #12561
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
SQLLAB_BACKEND_PERSISTENCEis True insuperset_config.pyADDITIONAL INFORMATION