Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CI): remove duplicate hive and presto tests #12638

Merged
merged 1 commit into from Jan 21, 2021

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Jan 21, 2021

SUMMARY

Just realized we've had duplicate CI workflows for Presto and Hive for a couple of months.

The unfortunate series of events happened as follows:

  1. I split Presto and Hive into their own workflows in September: build: split hive and presto tests to separate jobs #10821
  2. They were added back to superset-frontend.yml in docs(new docs site): removes old sphinx doc site with gatsby #10784 , probably by an improper handling of merge conflicts
  3. @etr2460 split them again in November: build: split python CI jobs #11794 --- by that time I already forgot I already did the split just two months ago.... 🤦
  4. I combined them into one workflow in build: try to speed up Github workflows #12090 , in hope to reduce jobs in queue.

This PR cleans up the Presto and Hive tests' standalone workflow files but keep the combined one superset-frontend-hive-presto.yml.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

CI should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

Codecov Report

Merging #12638 (139c27c) into master (7577f47) will decrease coverage by 3.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12638      +/-   ##
==========================================
- Coverage   66.80%   63.19%   -3.62%     
==========================================
  Files        1017      486     -531     
  Lines       49730    29982   -19748     
  Branches     4864        0    -4864     
==========================================
- Hits        33224    18948   -14276     
+ Misses      16383    11034    -5349     
+ Partials      123        0     -123     
Flag Coverage Δ
cypress ?
javascript ?
python 63.19% <ø> (-0.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/db_engine_specs/hive.py 54.61% <0.00%> (-29.24%) ⬇️
superset/db_engine_specs/sqlite.py 65.62% <0.00%> (-9.38%) ⬇️
superset/databases/commands/create.py 83.67% <0.00%> (-8.17%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/connectors/sqla/models.py 84.31% <0.00%> (-6.28%) ⬇️
superset/databases/commands/test_connection.py 84.78% <0.00%> (-4.35%) ⬇️
superset/utils/celery.py 96.42% <0.00%> (-3.58%) ⬇️
superset/models/core.py 85.59% <0.00%> (-3.27%) ⬇️
... and 541 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7577f47...139c27c. Read the comment docs.

@ktmud ktmud merged commit c68cec7 into apache:master Jan 21, 2021
@ktmud ktmud deleted the remove-duplicate-tests branch January 21, 2021 04:27
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants