Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep old names from screenshot images to pypi releases #12664

Merged
merged 3 commits into from Jan 27, 2021

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jan 21, 2021

SUMMARY

Partially fixes broken images links on Pypi: https://pypi.org/project/apache-superset/

Note same effect on 1.0 branch: https://github.com/apache/superset/tree/1.0

Some images do not render on Pypi because we need to access the raw path on github:
pypi/warehouse#5246

These images were renamed after the 1.0.0 cut. We should think about a way to support these links for a certain period of time

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Jan 21, 2021

Codecov Report

Merging #12664 (5dd3f86) into master (734fb75) will decrease coverage by 3.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12664      +/-   ##
==========================================
- Coverage   66.85%   63.40%   -3.45%     
==========================================
  Files        1018      488     -530     
  Lines       49776    30115   -19661     
  Branches     4869        0    -4869     
==========================================
- Hits        33278    19095   -14183     
+ Misses      16375    11020    -5355     
+ Partials      123        0     -123     
Flag Coverage Δ
cypress ?
javascript ?
python 63.40% <ø> (-0.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/db_engine_specs/hive.py 73.84% <0.00%> (-10.00%) ⬇️
superset/databases/commands/create.py 83.67% <0.00%> (-8.17%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/connectors/sqla/models.py 84.31% <0.00%> (-6.28%) ⬇️
superset/db_engine_specs/sqlite.py 90.62% <0.00%> (-6.25%) ⬇️
superset/databases/commands/test_connection.py 84.78% <0.00%> (-4.35%) ⬇️
superset/utils/celery.py 96.42% <0.00%> (-3.58%) ⬇️
superset/models/core.py 85.59% <0.00%> (-3.27%) ⬇️
... and 561 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 734fb75...6f41f3a. Read the comment docs.

@dpgaspar dpgaspar merged commit 044d1ae into apache:master Jan 27, 2021
@dpgaspar dpgaspar deleted the fix/1-0-README branch January 27, 2021 13:53
villebro pushed a commit that referenced this pull request Jan 30, 2021
…2664)

* fix: keep old names from screenshot images to pypi releases

* change db logos to github raw content

* add gallery link
@mistercrunch mistercrunch added 🍒 1.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M v1.0.1 🍒 1.0.1 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants