[Change in Progress] Added Advcanced Analytics panel and Chart Options for Line chart #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vera-liu
force-pushed
the
vliu_line_controls
branch
3 times, most recently
from
a6db13a
to
7825a46
Compare
vera-liu
force-pushed
the
vliu_line_controls
branch
from
7825a46
to
c0db2d4
Compare
vera-liu
force-pushed
the
vliu_line_controls
branch
from
cb8c617
to
ea4f555
Compare
vera-liu
changed the title
bkyryliuk
reviewed
Oct 7, 2016
|
|
||
| function mapStateToProps(state) { | ||
| return { | ||
| rolling: state.rolling, |
There was a problem hiding this comment.
I am not sure if they should be top level args in the redux store, maybe state.viz.advancedAnalytics or state.explore.advancedAnalytics
There was a problem hiding this comment.
Hey, sorry this one is not ready yet, all the formdata will be moved after #1281, I'll modify this PR after merging 1281
bkyryliuk
reviewed
Oct 7, 2016
|
|
||
| function mapStateToProps(state) { | ||
| return { | ||
| lineStyle: state.lineStyle, |
vera-liu
changed the title
|
Now that we're going with the config-driven approach I don't think this is needed anymore. |
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done:
Old:
New:
Todo: