Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a note about using Draft PR's importance #12678

Merged
merged 3 commits into from
Jan 23, 2021

Conversation

amitmiran137
Copy link
Member

@amitmiran137 amitmiran137 commented Jan 22, 2021

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

the major fo work flows will be skiped
image

TEST PLAN

ADDITIONAL INFORMATION

  • [x ] Has associated issue: #
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@amitmiran137 amitmiran137 marked this pull request as ready for review January 22, 2021 06:22
@codecov-io
Copy link

codecov-io commented Jan 22, 2021

Codecov Report

Merging #12678 (ac333c9) into master (7838f03) will decrease coverage by 3.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12678      +/-   ##
==========================================
- Coverage   66.93%   63.34%   -3.60%     
==========================================
  Files        1018      486     -532     
  Lines       49792    29983   -19809     
  Branches     4877        0    -4877     
==========================================
- Hits        33328    18992   -14336     
+ Misses      16341    10991    -5350     
+ Partials      123        0     -123     
Flag Coverage Δ
cypress ?
javascript ?
python 63.34% <ø> (-0.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/db_engine_specs/hive.py 54.61% <0.00%> (-29.24%) ⬇️
superset/databases/commands/create.py 83.67% <0.00%> (-8.17%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/connectors/sqla/models.py 84.31% <0.00%> (-6.28%) ⬇️
superset/db_engine_specs/sqlite.py 90.62% <0.00%> (-6.25%) ⬇️
superset/databases/commands/test_connection.py 84.78% <0.00%> (-4.35%) ⬇️
superset/utils/celery.py 96.42% <0.00%> (-3.58%) ⬇️
superset/models/core.py 85.59% <0.00%> (-3.27%) ⬇️
... and 543 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7838f03...ac333c9. Read the comment docs.

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small grammar nits

CONTRIBUTING.md Outdated Show resolved Hide resolved
amitmiran137 and others added 2 commits January 22, 2021 09:57
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
@junlincc junlincc added the doc:developer Developer documentation label Jan 22, 2021
@villebro villebro merged commit 0143a98 into apache:master Jan 23, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels doc:developer Developer documentation size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants