Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore[explore]: Save date if Ok not clicked #12731

Merged
merged 2 commits into from Jan 25, 2021

Conversation

nikolagigic
Copy link
Contributor

@nikolagigic nikolagigic commented Jan 25, 2021

SUMMARY

If the user does not click on Ok button in Time Range date picker but clicks outside of the modal instead, the picked date is saved.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Age.distribution.mp4

TEST PLAN

  1. Go to 'Explore'
  2. Click on 'TIME RANGE'
  3. Choose 'Custom' as the 'RANGE TYPE'
  4. Choose 'Specific Date/Time' as the 'START'
  5. Click on a date
  6. Move the mouse off of the 'TIME RANGE' modal and click

ADDITIONAL INFORMATION

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

customeFrame has 3 Datepicker.

@junlincc junlincc added v1.0.1bash! explore:time Related to the time filters in Explore labels Jan 25, 2021
@codecov-io
Copy link

codecov-io commented Jan 25, 2021

Codecov Report

Merging #12731 (a7898f6) into master (bcbd8f9) will decrease coverage by 14.34%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #12731       +/-   ##
===========================================
- Coverage   62.75%   48.40%   -14.35%     
===========================================
  Files        1021      477      -544     
  Lines       49960    17091    -32869     
  Branches     4891     4399      -492     
===========================================
- Hits        31352     8273    -23079     
+ Misses      18408     8818     -9590     
+ Partials      200        0      -200     
Flag Coverage Δ
cypress 48.40% <ø> (?)
javascript ?
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/controls/DateFilterControl/frame/CustomFrame.tsx 30.61% <ø> (+16.32%) ⬆️
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...rc/dashboard/util/getLayoutComponentFromChartId.js 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...src/SqlLab/utils/reduxStateToLocalStorageHelper.js 7.69% <0.00%> (-92.31%) ⬇️
...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx 11.76% <0.00%> (-88.24%) ⬇️
...d/src/dashboard/util/updateComponentParentsList.js 0.00% <0.00%> (-87.50%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
... and 930 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcbd8f9...0001963. Read the comment docs.

@junlincc junlincc self-requested a review January 25, 2021 11:11
Copy link
Member

@junlincc junlincc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhaoyongjie zhaoyongjie self-requested a review January 25, 2021 11:46
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie self-requested a review January 25, 2021 11:47
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit 9ab804b into apache:master Jan 25, 2021
villebro pushed a commit that referenced this pull request Jan 25, 2021
* Save date if Ok not clicked

* answering. comments
@rusackas rusackas removed the bash! label May 14, 2021
@mistercrunch mistercrunch added 🍒 1.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:time Related to the time filters in Explore size/XS v1.0.1 🍒 1.0.1 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[explore]Date picker randomly changes date
7 participants