Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: wrong port name in NOTES.txt #12743

Merged
merged 1 commit into from Jan 29, 2021

Conversation

maddyobrienjones
Copy link
Contributor

SUMMARY

in instructions to run superset, says to port forward port 8080 when in the values.yaml file, it is port 8088

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Jan 25, 2021

Codecov Report

Merging #12743 (fa619f6) into master (8c29ba8) will increase coverage by 3.87%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12743      +/-   ##
==========================================
+ Coverage   62.80%   66.67%   +3.87%     
==========================================
  Files        1022     1022              
  Lines       49973    49992      +19     
  Branches     4892     4892              
==========================================
+ Hits        31385    33334    +1949     
+ Misses      18388    16533    -1855     
+ Partials      200      125      -75     
Flag Coverage Δ
cypress 50.92% <ø> (?)
javascript 61.34% <ø> (+0.46%) ⬆️
python 63.72% <ø> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/db_engine_specs/hive.py 73.84% <0.00%> (-17.31%) ⬇️
superset/db_engine_specs/presto.py 81.38% <0.00%> (-7.15%) ⬇️
superset/views/database/mixins.py 80.70% <0.00%> (-1.76%) ⬇️
...-frontend/src/datasource/ChangeDatasourceModal.tsx 84.14% <0.00%> (-1.04%) ⬇️
...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx 74.71% <0.00%> (-0.87%) ⬇️
...ntend/src/views/CRUD/annotation/AnnotationList.tsx 76.08% <0.00%> (-0.84%) ⬇️
superset/models/core.py 88.04% <0.00%> (-0.82%) ⬇️
...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx 60.41% <0.00%> (-0.64%) ⬇️
...tend/src/views/CRUD/annotation/AnnotationModal.tsx 66.14% <0.00%> (-0.53%) ⬇️
... and 195 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c29ba8...fa619f6. Read the comment docs.

@maddyobrienjones maddyobrienjones changed the title wrong port name in NOTES.txt docs: wrong port name in NOTES.txt Jan 25, 2021
@junlincc junlincc added doc:developer Developer documentation new:contributor The author is a new contributor labels Jan 27, 2021
@srinify
Copy link
Contributor

srinify commented Jan 29, 2021

Good catch, thanks for the contribution @maddyobrienjones

@srinify srinify merged commit 20c1ea7 into apache:master Jan 29, 2021
@maddyobrienjones maddyobrienjones deleted the port_number_notes_fix branch January 29, 2021 20:18
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels doc:developer Developer documentation new:contributor The author is a new contributor size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants