[SQLLab] Fix the usage of Redux DevTools Enhancer #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| enhancerWithPersistState = compose( | ||
| persistState(), window.devToolsExtension && window.devToolsExtension() | ||
| ); | ||
| const composeEnhancers = window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__ || compose; |
There was a problem hiding this comment.
this triggers the linter, breaks the build, to fix please add /* eslint-disable no-underscore-dangle */ on the line right above
|
Nice thanks for the pro-active fix! |
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
…che#1278) * feat(legacy-preset-chart-big-number): add timestamp above number * add timestamp formatting * revert to fallback warning when no timestamp * fix smart date formatting * fix test Co-authored-by: Ivan Krsnik <ivan.krsnik@unipart.io>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
…che#1278) * feat(legacy-preset-chart-big-number): add timestamp above number * add timestamp formatting * revert to fallback warning when no timestamp * fix smart date formatting * fix test Co-authored-by: Ivan Krsnik <ivan.krsnik@unipart.io>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
…che#1278) * feat(legacy-preset-chart-big-number): add timestamp above number * add timestamp formatting * revert to fallback warning when no timestamp * fix smart date formatting * fix test Co-authored-by: Ivan Krsnik <ivan.krsnik@unipart.io>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
…che#1278) * feat(legacy-preset-chart-big-number): add timestamp above number * add timestamp formatting * revert to fallback warning when no timestamp * fix smart date formatting * fix test Co-authored-by: Ivan Krsnik <ivan.krsnik@unipart.io>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue caused by not having the extension installed could be solved by using
However, it was really confusing. So, we're deprecating the enhancer in favour of a more clear API.
I'm happy that Airbnb devs found the extension useful. If you have any other suggestions about it, let me know (since we're both building tools for development).
Fixes #1223, #1228, #1238.