Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 1.0.0 release notes update: media + feature flags #12781

Merged
merged 2 commits into from Jan 27, 2021

Conversation

garden-of-delete
Copy link
Contributor

SUMMARY

This PR does two things:

  1. Responds to feedback from @villebro and others asking for increased quality in the media embedded in the 1.0.0 release notes.
  2. Adds a blurb about feature flags to the Summary section of the release notes, and links to a WIP table in the Superset ASF docs documenting the flags and back-end dependencies relevant to the new features in 1.0.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

No test plan needed.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Jan 26, 2021

Codecov Report

Merging #12781 (f6e965e) into master (b32b6cd) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12781      +/-   ##
==========================================
- Coverage   66.93%   66.78%   -0.15%     
==========================================
  Files        1019     1022       +3     
  Lines       49822    50049     +227     
  Branches     4875     4914      +39     
==========================================
+ Hits        33350    33427      +77     
- Misses      16349    16498     +149     
- Partials      123      124       +1     
Flag Coverage Δ
cypress 50.87% <ø> (-0.06%) ⬇️
javascript 61.68% <ø> (+0.73%) ⬆️
python 63.74% <ø> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
...rontend/src/explore/components/DatasourcePanel.tsx 80.00% <0.00%> (-10.91%) ⬇️
superset/db_engine_specs/hive.py 73.84% <0.00%> (-10.00%) ⬇️
...ntend/src/dashboard/components/PropertiesModal.jsx 75.67% <0.00%> (-7.21%) ⬇️
superset/db_engine_specs/presto.py 81.38% <0.00%> (-7.15%) ⬇️
...ashboard/components/nativeFilters/ColumnSelect.tsx 55.55% <0.00%> (-5.06%) ⬇️
...et-frontend/src/components/Menu/LanguagePicker.tsx 64.28% <0.00%> (-4.95%) ⬇️
...frontend/src/dashboard/containers/FiltersBadge.tsx 89.28% <0.00%> (-3.31%) ⬇️
superset-frontend/src/utils/common.js 70.96% <0.00%> (-3.23%) ⬇️
...nd/src/explore/components/ExploreViewContainer.jsx 77.24% <0.00%> (-2.76%) ⬇️
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b32b6cd...f6e965e. Read the comment docs.

@junlincc junlincc added the doc:developer Developer documentation label Jan 27, 2021
@srinify srinify merged commit f4ccc63 into apache:master Jan 27, 2021
@garden-of-delete garden-of-delete deleted the robert/release-notes-1-0-flags branch January 27, 2021 19:55
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels doc:developer Developer documentation preset-io 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants