reduce chunk size for countries table #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One user reported the load of the "countries" table exceed max_allowed_packet which in some configurations can be as low as 1MB. Changing the chunk size from 500 to 50 has a small cost on the initial load of the data (one additional second to the 17 taken previously) while being more universally usable without changing the configuration of the mysql server. The new packet size is estimated to be about 500KB. The committer has not checked other tables
|
Thanks! This would fix #457 |
|
caravel load_examples -- pretty insignificant, merging |
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
…timeseries charts (apache#1279) * feat(plugin-chart-echarts): add support for series values * feat(plugin-chart-echarts): name * fix: lint * fix: extract control * fix: extract control
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
…timeseries charts (apache#1279) * feat(plugin-chart-echarts): add support for series values * feat(plugin-chart-echarts): name * fix: lint * fix: extract control * fix: extract control
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
…timeseries charts (apache#1279) * feat(plugin-chart-echarts): add support for series values * feat(plugin-chart-echarts): name * fix: lint * fix: extract control * fix: extract control
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
…timeseries charts (apache#1279) * feat(plugin-chart-echarts): add support for series values * feat(plugin-chart-echarts): name * fix: lint * fix: extract control * fix: extract control
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FROM https://trello.com/c/3JWvIC8T/8-aggiungere-una-faq-per-grandezza-pacchetti-mysql
May I suggest to change the chunk size of the countries query?
While this slow the initial load from 17 to 18 seconds on this machine (for the sqlite db) it should be a non issue.
With a chunk size of 50 instead of 500 the packet size should be less than 500KB instead than the actual more than 4MB
The committer has not checked other tables