Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(time-table): add row limit control for timeseries table #12887

Merged
merged 1 commit into from Feb 4, 2021

Conversation

maloun96
Copy link
Contributor

@maloun96 maloun96 commented Feb 2, 2021

SUMMARY

Add row limit control for timeseries table

After

DEV.Explore.-.mp4

TEST PLAN

Create new Timeseries Table Chart

ADDITIONAL INFORMATION

@codecov-io
Copy link

Codecov Report

Merging #12887 (6881652) into master (2adfb85) will decrease coverage by 1.50%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12887      +/-   ##
==========================================
- Coverage   64.89%   63.39%   -1.51%     
==========================================
  Files        1024      489     -535     
  Lines       50168    30198   -19970     
  Branches     5148        0    -5148     
==========================================
- Hits        32557    19143   -13414     
+ Misses      17433    11055    -6378     
+ Partials      178        0     -178     
Flag Coverage Δ
cypress ?
javascript ?
python 63.39% <ø> (-0.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/db_engine_specs/hive.py 73.84% <0.00%> (-17.31%) ⬇️
superset/databases/commands/create.py 83.67% <0.00%> (-8.17%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/connectors/sqla/models.py 84.31% <0.00%> (-6.28%) ⬇️
superset/db_engine_specs/sqlite.py 90.62% <0.00%> (-6.25%) ⬇️
superset/databases/commands/test_connection.py 84.78% <0.00%> (-4.35%) ⬇️
superset/utils/celery.py 86.20% <0.00%> (-3.45%) ⬇️
superset/models/core.py 85.59% <0.00%> (-3.27%) ⬇️
... and 548 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2adfb85...6881652. Read the comment docs.

@villebro villebro changed the title Add row limit control for timeseries table feat: add row limit control for timeseries table Feb 3, 2021
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@junlincc junlincc changed the title feat: add row limit control for timeseries table feat(time-table): add row limit control for timeseries table Feb 4, 2021
@junlincc junlincc self-requested a review February 4, 2021 06:25
@junlincc junlincc added explore:control Related to the controls panel of Explore viz:charts:timetable Related to the Time Table chart labels Feb 4, 2021
Copy link
Member

@junlincc junlincc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ Approve as product sign-off.

Screen.Recording.2021-02-03.at.10.24.29.PM.mov

Before:
Screen Shot 2021-02-03 at 10 26 42 PM

@zhaoyongjie zhaoyongjie self-requested a review February 4, 2021 06:28
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit 137cf5d into apache:master Feb 4, 2021
villebro pushed a commit to preset-io/superset that referenced this pull request Feb 4, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:control Related to the controls panel of Explore size/XS viz:charts:timetable Related to the Time Table chart 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants