Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the untranslated text content of Dashboard page #13024

Merged
merged 3 commits into from Feb 9, 2021

Conversation

cdmikechen
Copy link
Contributor

SUMMARY

fix the untranslated text content of Dashboard page. At present, some fields are not translated

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

dashboardlist

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 9, 2021
@codecov-io
Copy link

codecov-io commented Feb 9, 2021

Codecov Report

Merging #13024 (18b7738) into master (d5e6190) will increase coverage by 19.58%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #13024       +/-   ##
===========================================
+ Coverage   53.38%   72.97%   +19.58%     
===========================================
  Files         489      546       +57     
  Lines       17315    20175     +2860     
  Branches     4482     5268      +786     
===========================================
+ Hits         9244    14723     +5479     
+ Misses       8071     5327     -2744     
- Partials        0      125      +125     
Flag Coverage Δ
cypress 53.38% <100.00%> (ø)
javascript 61.86% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/views/CRUD/dashboard/DashboardCard.tsx 83.78% <ø> (+7.78%) ⬆️
...rontend/src/views/CRUD/dashboard/DashboardList.tsx 80.18% <ø> (+8.13%) ⬆️
...rontend/src/components/ListView/CardSortSelect.tsx 95.83% <100.00%> (+16.88%) ⬆️
...rset-frontend/src/components/ListView/ListView.tsx 99.03% <100.00%> (+6.90%) ⬆️
...tend/src/filters/components/Select/controlPanel.ts 18.18% <0.00%> (-81.82%) ⬇️
superset-frontend/src/views/index.tsx 25.00% <0.00%> (-75.00%) ⬇️
superset-frontend/src/SqlLab/index.tsx 25.00% <0.00%> (-75.00%) ⬇️
...ntend/src/filters/components/Range/controlPanel.ts 25.00% <0.00%> (-75.00%) ⬇️
superset-frontend/src/views/App.tsx 25.58% <0.00%> (-74.42%) ⬇️
...et-frontend/src/filters/components/Select/index.ts 40.00% <0.00%> (-60.00%) ⬇️
... and 407 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5e6190...18b7738. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! It seems you need to fix a linting error - apart from that LGTM

@cdmikechen
Copy link
Contributor Author

@villebro
have done fixed linting error. Thank you !

@nytai nytai merged commit 4ba98bf into apache:master Feb 9, 2021
amitmiran137 added a commit to simcha90/incubator-superset that referenced this pull request Feb 10, 2021
* master:
  fix: UI toast typo (apache#13026)
  feat(db engines): add support for Opendistro Elasticsearch (AWS ES) (apache#12602)
  fix(build): black failing on master, add to required checks (apache#13039)
  fix: time filter db migration optimization (apache#13015)
  fix: untranslated text content of Dashboard page (apache#13024)
  fix(ci): remove signature requirements for commits to master (apache#13034)
  fix: add alerts and report to default config (apache#12999)
  docs(changelog): add entries for 1.0.1 (apache#12981)
  ci: skip cypress if no code changes (apache#12982)
  chore: add cypress required checks for branch protection (apache#12970)
  Refresh dashboard list after bulk delete (apache#12945)
  Updates storybook to version 6.1.17 (apache#13014)
  feat: Save datapanel state in local storage (apache#12996)
  fix: added text and changed margins (apache#12923)
  chore: Swap Slack Url 2 more places (apache#13004)
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Feb 14, 2021
* fix: fix the untranslated text content of Dashboard page

* fix: add the untranslated text content of Dashboard page in messages.pot

* fix linting error

Co-authored-by: chenx <yuxiang1989>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants