Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(list view): table sort icon alignment #13139

Merged
merged 1 commit into from Feb 16, 2021
Merged

style(list view): table sort icon alignment #13139

merged 1 commit into from Feb 16, 2021

Conversation

nytai
Copy link
Member

@nytai nytai commented Feb 15, 2021

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screen Shot 2021-02-15 at 10 53 31 AM
After:
Screen Shot 2021-02-15 at 10 53 49 AM

TEST PLAN

  • 👀confirm tableview sort headers are aligned with the header text

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@nytai nytai changed the title style: table sort icon alignment style(list view): table sort icon alignment Feb 15, 2021
@nytai nytai requested a review from rusackas February 16, 2021 03:13
@nytai nytai merged commit 8b40bf6 into apache:master Feb 16, 2021
@nytai nytai deleted the tai/fix-sort-alignment branch February 16, 2021 19:23
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willbarrett willbarrett willbarrett approved these changes

@rusackas rusackas Awaiting requested review from rusackas

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nytai @willbarrett @mistercrunch