Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cross-filters): apply cross filters for all charts #13178

Merged
merged 1 commit into from Feb 17, 2021
Merged

fix(cross-filters): apply cross filters for all charts #13178

merged 1 commit into from Feb 17, 2021

Conversation

simcha90
Copy link
Contributor

SUMMARY

This PR apply cross filter functionality for all charts on dashboard until will be implemented it's scoping

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-02-17.at.17.41.19.mov

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@junlincc junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label Feb 17, 2021
@villebro villebro mentioned this pull request Feb 17, 2021
Closed
3 tasks
villebro
villebro approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Note to self, we need to implement similar NULL formatting in the Select component as we have in the table chart.

@villebro villebro merged commit 4502155 into apache:master Feb 17, 2021
@junlincc junlincc added dashboard:cross-filters Related to the Dashboard cross filters and removed dashboard:native-filters Related to the native filters of the Dashboard labels Apr 27, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:cross-filters Related to the Dashboard cross filters size/S 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@simcha90 @villebro @mistercrunch @junlincc