fix(explore): Reset values in TextControl only when datasource changes

[kgabryje]

SUMMARY

Due to recent changes in #12782 regarding resetting control values when datasource changes, debounce in TextControl component stopped working properly. This was caused by comparing props.value with state.value and setting state.value to props.value if they were not equal. Because of using 0.5s debounce, props and state values were always unequal when user typed a new value. This PR fixes the issue by adding a comparison of props and state datasource and updating value only when datasources are not equal.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: see #13191
After:
https://user-images.githubusercontent.com/15073128/108376726-8ebab080-7203-11eb-8ef2-f3ef73aab2f3.mov

TEST PLAN

ADDITIONAL INFORMATION

• Has associated issue: fixes [Explore]Customize X-axis debounce is broken #13191
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

CC: @villebro @junlincc
@nikolagigic @mayurnewase please help review this PR, thanks! (from junlin)

[junlincc]

tested locally, LGTM! ✅ Thank you for the fix!

[villebro]

LGTM, thanks for fixing 👍 The fact that a few simple and seemingly unrelated changes caused a regression like this makes me think we'd need to rethink how these components are structured.

[ktmud]

Also related #11985

[ktmud]

Hi @junlincc @pkdotson @villebro @kgabryje , going back to the original PR (#12782 ) that introduced this bug, I don't think TextControl should be included in the controls that reset values when users change datasource. Because most of the time, the input value in TextControl is not datasource specific---i.e. they are not related to columns and metrics. As discussed in #12782, the original input (axis labels, bounds, etc.) could be useful when plotting with a new datasource.

I'm going to remove the reset logic in my control refactoring PR if you don't mind.

[junlincc]

@ktmud remove it all or just text input?

[ktmud]

@junlincc Just the text control. As discussed in #12782 (comment) , the reset logic should be only applied to controls that depend on datasource columns/metrics.

[junlincc]

@ktmud
i am curious when users change dataset, do they also change chart type as well?
do users create new chart by clicking +button, or from the explore view by changing dataset and chart type.