test: add Tests and Storybook for AsyncAceEditor #13241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktmud
changed the title
ktmud
reviewed
Feb 21, 2021
| constructor(stringUrl: string) { | ||
| this.url = stringUrl; | ||
| this.onMessage = () => {}; | ||
| this.terminate = () => {}; |
There was a problem hiding this comment.
Do you mind noting why is this needed? Not sure how it this related to AsyncAceEditor.
There was a problem hiding this comment.
During ReactAce willUnmount cycle the brace package invokes Worker terminate.
There was a problem hiding this comment.
Thanks for the info! Makes sense.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
-Adds tests for the
AsyncAceEditorcomponent and a storybook entry with controls.-Moves
AsyncAceEditorcomponent to its own folderBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
1 - Execute all tests
2 - All tests should pass
@rusackas
ADDITIONAL INFORMATION