ci: always execute tests on non-PRs

[villebro]

SUMMARY

When working on a branch before opening a PR I noticed that the conditional test skipping doesn't work properly when PR_NUMBER isn't available (=not a PR). This changes tests to always execute when it isn't a PR, for example after merging or when just working on a branch.

BEFORE

AFTER

TEST PLAN

Local testing + ShellCheck:

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[ktmud]

I wonder whether it'd make the workflow scripts easier to understand if we use step output instead of outcome , considering all future steps will have to check the step results anyway.

for FILE in ${FILES}
do
  for REGEX in "${REGEXES[@]}"
  do
    if [[ "${FILE}" =~ ${REGEX} ]]; then
      echo "Detected changes in following file: ${FILE}"
      exit 0
    fi
  done
done
echo "No matching file changes detected"
echo "::set-output name=no_matching_change::true"

Then maybe we can also use condition check on the check job itself (if: github.event_name == 'pull_request') to address what this PR is trying to solve? I.e. run the file change check only on pull requests, and skip future tasks only if steps.check_file_change.output.no_matching_change = true.

[dpgaspar]

Tested this change on a branch and it works!

[villebro]

I wonder whether it'd make the workflow scripts easier to understand if we use step output instead of outcome , considering all future steps will have to check the step results anyway.

for FILE in ${FILES}
do
  for REGEX in "${REGEXES[@]}"
  do
    if [[ "${FILE}" =~ ${REGEX} ]]; then
      echo "Detected changes in following file: ${FILE}"
      exit 0
    fi
  done
done
echo "No matching file changes detected"
echo "::set-output name=no_matching_change::true"

Then maybe we can also use condition check on the check job itself (if: github.event_name == 'pull_request') to address what this PR is trying to solve? I.e. run the file change check only on pull requests, and skip future tasks only if steps.check_file_change.output.no_matching_change = true.

This is a really good idea; I'll merge this one first to fix the problem but will follow up with something along these lines if it works well.