test: CacheLabel #13318
Merged
test: CacheLabel #13318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geido
approved these changes
Feb 24, 2021
| import moment from 'moment'; | ||
| import { TooltipContent } from './TooltipContent'; | ||
|
|
||
| test('Rendering TooltipContent correctly - no timestep', () => { |
There was a problem hiding this comment.
Small typo timestep to be timestamp
There was a problem hiding this comment.
Copy and paste error rsrsrs
Thanks
| ); | ||
| }); | ||
|
|
||
| test('Rendering TooltipContent correctly - with timestep', () => { |
There was a problem hiding this comment.
Same typo. Found also in the other tests
Codecov Report
@@ Coverage Diff @@
## master #13318 +/- ##
==========================================
- Coverage 77.20% 72.74% -4.46%
==========================================
Files 872 577 -295
Lines 45101 21021 -24080
Branches 5435 5375 -60
==========================================
- Hits 34820 15292 -19528
+ Misses 10158 5606 -4552
Partials 123 123
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pkdotson
approved these changes
Feb 25, 2021
rusackas
approved these changes
Feb 25, 2021
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
* add HTMLAttributes on Label Component * Split TooltipContent * moving "CacheLabel.jsx" to "CacheLabel" folder * remove "data-test-id" * Fix timestamp name * removing unused file
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
TolltipContent.TEST PLAN
No change in behavior. All tests must pass.