Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Adds storybook to ConfirmStatusChange component #13412

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

  • Adds storybook to ConfirmStatusChange component
  • Moves ConfirmStatusChange tests to component's folder

TEST PLAN

1 - Execute ConfirmStatusChange tests
2- All tests should pass

@rusackas

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #13412 (3e2aee3) into master (f19a830) will decrease coverage by 3.31%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13412      +/-   ##
==========================================
- Coverage   76.33%   73.01%   -3.32%     
==========================================
  Files         900      600     -300     
  Lines       45596    21158   -24438     
  Branches     5491     5416      -75     
==========================================
- Hits        34804    15449   -19355     
+ Misses      10648     5582    -5066     
+ Partials      144      127      -17     
Flag Coverage Δ
cypress 57.95% <ø> (-0.85%) ⬇️
hive ?
javascript 62.72% <0.00%> (-0.04%) ⬇️
mysql ?
postgres ?
presto ?
python ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onfirmStatusChange/ConfirmStatusChange.stories.tsx 0.00% <0.00%> (ø)
...ntend/src/components/ConfirmStatusChange/index.tsx 96.15% <ø> (ø)
...erset-frontend/src/SqlLab/components/ResultSet.tsx 68.46% <0.00%> (-0.31%) ⬇️
superset/dashboards/commands/delete.py
superset/databases/commands/importers/v1/utils.py
superset/db_engine_specs/trino.py
superset/reports/commands/create.py
superset/charts/commands/export.py
superset/commands/utils.py
superset/security/__init__.py
... and 356 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f19a830...27dec3d. Read the comment docs.

@rusackas rusackas merged commit 6e48251 into apache:master Mar 9, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels test:component 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants