Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sqllab-presto] adding partition information #1342

Merged
merged 1 commit into from
Oct 19, 2016

Conversation

mistercrunch
Copy link
Member

Showing latest partition information as a header in the TableElement component, plus a "copy to cilpboard" icon to get a query to get detailed information about existing partitions.

Side-missions:

  • a new abstraction to provide per-database-engine extra table metadata, this runs async and independently from the common table metadata endpoint to avoid slowing down showing the column/type info to users
  • my first mochajs unit tests, I had to play some small tricks here to decouple my component from react-redux for the react tests to run
  • overdue rename of SqlEditorTopToolbar to SqlEditorLeftBar
  • a bit of refactoring in the python tests
  • a very basic python test, just making sure the endpoint works, no Presto mocking or anything fancy there
  • minor cosmetic touchup of CopyToClipboard component to allow a node in the tooltip and removing unwanted  
    screen shot 2016-10-13 at 5 58 38 pm
    screen shot 2016-10-13 at 5 58 23 pm

@bkyryliuk @ascott

@mistercrunch
Copy link
Member Author

ping!

@mistercrunch
Copy link
Member Author

I'm going to babysit this one in staging

@mistercrunch mistercrunch merged commit c255e89 into apache:master Oct 19, 2016
@mistercrunch mistercrunch deleted the parts branch October 19, 2016 16:17
neevany pushed a commit to Kieraya/caravel that referenced this pull request Oct 24, 2016
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
* feat(core): add support for adhoc columns

* simplify import

* revert simplification due to codecov

* fix filter column type

* fix pivot v2 groupbys

* remove redundant import

* Add new type guards

* move ColumnMeta type guards to chart-controls

* add type guard tests

* Fix typing and import errors

* Fix saved expression type guard

* Fix typing

* Remove redundant import

* Make Echarts and PivotTable handle AdhocColumns properly

* Fix lint

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
* feat(core): add support for adhoc columns

* simplify import

* revert simplification due to codecov

* fix filter column type

* fix pivot v2 groupbys

* remove redundant import

* Add new type guards

* move ColumnMeta type guards to chart-controls

* add type guard tests

* Fix typing and import errors

* Fix saved expression type guard

* Fix typing

* Remove redundant import

* Make Echarts and PivotTable handle AdhocColumns properly

* Fix lint

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
* feat(core): add support for adhoc columns

* simplify import

* revert simplification due to codecov

* fix filter column type

* fix pivot v2 groupbys

* remove redundant import

* Add new type guards

* move ColumnMeta type guards to chart-controls

* add type guard tests

* Fix typing and import errors

* Fix saved expression type guard

* Fix typing

* Remove redundant import

* Make Echarts and PivotTable handle AdhocColumns properly

* Fix lint

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
* feat(core): add support for adhoc columns

* simplify import

* revert simplification due to codecov

* fix filter column type

* fix pivot v2 groupbys

* remove redundant import

* Add new type guards

* move ColumnMeta type guards to chart-controls

* add type guard tests

* Fix typing and import errors

* Fix saved expression type guard

* Fix typing

* Remove redundant import

* Make Echarts and PivotTable handle AdhocColumns properly

* Fix lint

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.12.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant