Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: ignore Storybook stories in CodeCov #13421

Merged
merged 2 commits into from Mar 9, 2021

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Mar 2, 2021

SUMMARY

Ignore Storybook stories in CodeCov report so we don't get these unnecessary warnings:

image

Stories are a type of visual tests themselves and do not normally need test coverage.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina
Copy link
Member

michael-s-molina commented Mar 5, 2021

@ktmud some stories have .jsx extension. We should also ignore those while we don't change to typescript. Thanks for this PR!

@ktmud
Copy link
Member Author

ktmud commented Mar 5, 2021

@michael-s-molina These warnings only show up when you modify a file. I was hoping the next time we touch a .stories.jsx we would have converted it to .tsx already!

@michael-s-molina
Copy link
Member

@michael-s-molina These warnings only show up when you modify a file. I was hoping the next time we touch a .stories.jsx we would have converted it to .tsx already!

I didn't know that the warnings only show when we modify.. in that case we should be fine 😁

@michael-s-molina
Copy link
Member

Hum.. thinking a little more about it.. we have the case of executing the coverage script through npm.. in that case it will count .jsx stories. What do you think @ktmud ?

@ktmud
Copy link
Member Author

ktmud commented Mar 5, 2021

Yeah, it could have an impact on coverage percentages, but should not throw the warnings. So I'm adding .jsx to the ignore list anyway.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks!

@ktmud ktmud merged commit 9e964f4 into apache:master Mar 9, 2021
@ktmud ktmud deleted the codecov-ignore-stories branch March 9, 2021 22:45
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants