add node/npm versions to contributing.md #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 13, 2016 18:52
Closed
| @@ -90,6 +90,8 @@ Flask-Appbuilder itself comes bundled with jQuery and bootstrap. | |||
| While these may be phased out over time, these packages are currently not | |||
| managed with npm. | |||
|
|
|||
| ### Node/npm versions | |||
| Make sure you are using Node v6.2.2 and npm v3.9.5. | |||
There was a problem hiding this comment.
I just check out of curiosity what I'm using and I have node v5.10.1 and npm 3.10.5 . Maybe the note needs to sound a less strict. "Make sure you are using recent versions of node and npm. No problem have been seen with node>=5.10 and npm>=3.9"
|
LGTM |
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
… for Estonia (apache#1344) I have no idea how this happened, but most Estonian county codes were off by one. Unfortunately I couldn't compare it to latest data from naturalearthdata.com, since download links are currently down. Source: https://en.wikipedia.org/wiki/ISO_3166-2:EE#Counties Primary source: https://www.evs.ee/en/iso-3166-2-2020 (but I'm not going to pay 100 €)
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
… for Estonia (apache#1344) I have no idea how this happened, but most Estonian county codes were off by one. Unfortunately I couldn't compare it to latest data from naturalearthdata.com, since download links are currently down. Source: https://en.wikipedia.org/wiki/ISO_3166-2:EE#Counties Primary source: https://www.evs.ee/en/iso-3166-2-2020 (but I'm not going to pay 100 €)
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
… for Estonia (apache#1344) I have no idea how this happened, but most Estonian county codes were off by one. Unfortunately I couldn't compare it to latest data from naturalearthdata.com, since download links are currently down. Source: https://en.wikipedia.org/wiki/ISO_3166-2:EE#Counties Primary source: https://www.evs.ee/en/iso-3166-2-2020 (but I'm not going to pay 100 €)
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
… for Estonia (apache#1344) I have no idea how this happened, but most Estonian county codes were off by one. Unfortunately I couldn't compare it to latest data from naturalearthdata.com, since download links are currently down. Source: https://en.wikipedia.org/wiki/ISO_3166-2:EE#Counties Primary source: https://www.evs.ee/en/iso-3166-2-2020 (but I'm not going to pay 100 €)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @mistercrunch @bkyryliuk @vera-liu