Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alert/report): add notification method in alert report modal #13463

Merged
merged 1 commit into from Mar 16, 2021

Conversation

lilykuang
Copy link
Member

@lilykuang lilykuang commented Mar 4, 2021

SUMMARY

There was an issue related to add notification method button not showing up.

  • fix add notification method button
  • update test

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:
https://www.loom.com/share/5f7c6c295d5c4eeb8486f8842dd10cfd

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@lilykuang lilykuang marked this pull request as ready for review March 4, 2021 17:52
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #13463 (5620a21) into master (6026e7d) will increase coverage by 0.85%.
The diff coverage is 79.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13463      +/-   ##
==========================================
+ Coverage   72.74%   73.60%   +0.85%     
==========================================
  Files         906      605     -301     
  Lines       45654    21266   -24388     
  Branches     5516     5523       +7     
==========================================
- Hits        33212    15653   -17559     
+ Misses      12232     5486    -6746     
+ Partials      210      127      -83     
Flag Coverage Δ
cypress 57.94% <84.21%> (?)
hive ?
javascript 63.52% <73.52%> (+0.12%) ⬆️
mysql ?
postgres ?
presto ?
python ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dashboard/components/menu/MarkdownModeDropdown.tsx 87.50% <50.00%> (ø)
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 62.52% <50.00%> (+6.52%) ⬆️
...hboard/components/menu/BackgroundStyleDropdown.tsx 91.66% <75.00%> (ø)
.../src/dashboard/components/menu/PopoverDropdown.tsx 70.37% <77.77%> (ø)
.../src/dashboard/components/menu/WithPopoverMenu.tsx 86.79% <91.66%> (ø)
...ontend/src/dashboard/components/menu/HoverMenu.tsx 100.00% <100.00%> (ø)
superset-frontend/src/views/routes.tsx 56.81% <0.00%> (-6.82%) ⬇️
...ore/components/DatasourcePanel/DatasourcePanel.tsx 75.86% <0.00%> (-2.71%) ⬇️
...-frontend/src/datasource/ChangeDatasourceModal.tsx 84.33% <0.00%> (-1.03%) ⬇️
...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx 62.50% <0.00%> (-0.66%) ⬇️
... and 506 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 483405f...a7f4fb2. Read the comment docs.

@lilykuang lilykuang merged commit 10d8872 into apache:master Mar 16, 2021
@lilykuang lilykuang deleted the lily/alert-react-testing branch March 16, 2021 16:33
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants