fix: Typo in the positionJSON too large warning
#13467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix typo in the warning that gets displayed with the `positionJSON` is too large/long.
mrshu
changed the title
positionJSON is too large/long.positionJSON too large warning
Codecov Report
@@ Coverage Diff @@
## master #13467 +/- ##
=======================================
Coverage 77.62% 77.62%
=======================================
Files 962 962
Lines 49017 49017
Branches 6155 6155
=======================================
Hits 38050 38050
Misses 10763 10763
Partials 204 204
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
shivaylamba
approved these changes
Mar 5, 2021
michael-s-molina
approved these changes
May 22, 2021
|
Thanks @michael-s-molina -- I believe the PR should be ready to be merged. |
amitmiran137
approved these changes
Jun 28, 2021
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* Fix typo in the warning that gets displayed with the `positionJSON` is too large/long.
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* Fix typo in the warning that gets displayed with the `positionJSON` is too large/long.
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* Fix typo in the warning that gets displayed with the `positionJSON` is too large/long.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
positionJSONis too large/long.TEST PLAN
There is a good chance the localization depends on this string's exact value. I am not sure how to resolve that but I'd happily do that, should anyone provide some pointers.
ADDITIONAL INFORMATION