-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: script to benchmark DB migrations #13561
Conversation
9cf1207
to
fd75074
Compare
Codecov Report
@@ Coverage Diff @@
## master #13561 +/- ##
==========================================
+ Coverage 79.70% 79.85% +0.14%
==========================================
Files 945 943 -2
Lines 47975 47836 -139
Branches 6082 6019 -63
==========================================
- Hits 38240 38199 -41
+ Misses 9614 9518 -96
+ Partials 121 119 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing db migration performance with this creative approach! I have probably more questions rather than feedbacks on this one...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Will this destroy data currently in the local DB for the affected tables?
- Suggest boosting the test case row counts to something higher, perhaps 100, 10K, 100K to better simulate diverse use cases
96d9efd
to
b65f988
Compare
6a46eab
to
ad7c267
Compare
SUMMARY
Add a script
benchmark_migration.py
that when passed a migration script will:BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
ADDITIONAL INFORMATION