Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(explore): bump superset-ui 0.17.19 #13593

Merged
merged 1 commit into from Mar 12, 2021

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Mar 12, 2021

SUMMARY

For enable Metric drag and drop, bumping the latest superset-ui

HOW TO USE

setting ENABLE_EXPLORE_DRAG_AND_DROP to True

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #13593 (c7df61c) into master (d439da2) will decrease coverage by 3.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13593      +/-   ##
==========================================
- Coverage   76.29%   73.09%   -3.20%     
==========================================
  Files         910      606     -304     
  Lines       46310    21552   -24758     
  Branches     5613     5692      +79     
==========================================
- Hits        35330    15754   -19576     
+ Misses      10816     5662    -5154     
+ Partials      164      136      -28     
Flag Coverage Δ
cypress 56.73% <ø> (+1.58%) ⬆️
hive ?
javascript 63.06% <ø> (ø)
mysql ?
postgres ?
presto ?
python ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erset-frontend/src/SqlLab/components/ResultSet.tsx 68.22% <0.00%> (-0.30%) ⬇️
superset/common/query_object.py
superset/datasets/commands/export.py
superset/examples/birth_names.py
superset/utils/hashing.py
superset/db_engine_specs/mssql.py
superset/reports/commands/delete.py
superset/css_templates/schemas.py
superset/utils/decorators.py
superset/views/annotations.py
... and 351 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d439da2...c7df61c. Read the comment docs.

@zhaoyongjie zhaoyongjie merged commit 1a46f93 into apache:master Mar 12, 2021
@ktmud
Copy link
Member

ktmud commented Mar 12, 2021

This also brought in 0.17.18, which contains apache-superset/superset-ui#995 that changed how metrics are added to QueryObject in Table Chart's raw records mode. It hasn't been thoroughly tested without changes in #13434 so it might cause some bugs.

@ktmud
Copy link
Member

ktmud commented Mar 12, 2021

nvm, this one didn't update @superset-ui/core, which means we should be fine.

allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants