test: SelectAsyncControl #13638
Merged
test: SelectAsyncControl #13638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13638 +/- ##
==========================================
- Coverage 77.21% 73.39% -3.83%
==========================================
Files 912 621 -291
Lines 46449 22073 -24376
Branches 5725 5740 +15
==========================================
- Hits 35866 16200 -19666
+ Misses 10447 5729 -4718
- Partials 136 144 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
junlincc
requested review from
robdiciuccio
and removed request for
robdiciuccio
...rset-frontend/src/explore/components/controls/SelectAsyncControl/SelectAsyncControl.test.tsx
Outdated
Show resolved
Hide resolved
michael-s-molina
approved these changes
Mar 18, 2021
geido
reviewed
Mar 24, 2021
|
|
||
| beforeEach(() => { | ||
| jest.resetAllMocks(); | ||
| defaultProps = { |
There was a problem hiding this comment.
I think the same comment as the previous PRs. No need to replace the entire props
There was a problem hiding this comment.
Just linking the same answer to "stay registered"
There was a problem hiding this comment.
done by factory: #13753 (comment)
superset-frontend/src/explore/components/controls/SelectAsyncControl/index.jsx
Show resolved
Hide resolved
Merged
geido
approved these changes
Mar 25, 2021
rusackas
approved these changes
Mar 26, 2021
superset-frontend/src/explore/components/controls/SelectAsyncControl/index.jsx
Show resolved
Hide resolved
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
* SelectAsyncControl tests * fix: lint error * applying factory to props
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Tests for SelectAsyncControl
TEST PLAN
No behavior changes and the interface for importing was maintained.
All tests must pass.