Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: helm chart: Use stringData instead of data in Secrets and remove manual base64 encoding #13730

Merged
merged 1 commit into from Mar 22, 2021
Merged

refactor: helm chart: Use stringData instead of data in Secrets and remove manual base64 encoding #13730

merged 1 commit into from Mar 22, 2021

Conversation

andreas-eberle
Copy link
Contributor

SUMMARY

This PR switches to using Kubernetes' stringData field for Secrets instead of the data field. The benefits are:

  • we can avoid the manual base64 encoding of every field
  • when templating the helm chart, you can actually read the secrets and therefore better validate the generated template (e.g. injected config values).

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@craig-rueda craig-rueda merged commit 54b2bda into apache:master Mar 22, 2021
@andreas-eberle andreas-eberle deleted the helm-make-secret-more-readable branch March 23, 2021 09:40
@andreas-eberle
Copy link
Contributor Author

Thanks @craig-rueda for the quick review!

allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@andreas-eberle
Use stringData instead of data in Secrets and remove manual base64 en…
964d5ff 
…coding (apache#13730)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craig-rueda craig-rueda craig-rueda approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andreas-eberle @craig-rueda @mistercrunch