Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: SliceHeader #13888

Merged
merged 4 commits into from Apr 9, 2021
Merged

test: SliceHeader #13888

merged 4 commits into from Apr 9, 2021

Conversation

yardz
Copy link
Contributor

@yardz yardz commented Mar 31, 2021

SUMMARY

Tests for SliceHeader

@codecov
Copy link

codecov bot commented Mar 31, 2021 •
edited

Codecov Report

Merging #13888 (d7e79b6) into master (d54cc6d) will decrease coverage by 0.29%.
The diff coverage is 71.42%.

❗ Current head d7e79b6 differs from pull request most recent head 6f61a6f. Consider uploading reports for the commit 6f61a6f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13888      +/-   ##
==========================================
- Coverage   77.55%   77.26%   -0.30%     
==========================================
  Files         935      938       +3     
  Lines       47301    47727     +426     
  Branches     5907     6048     +141     
==========================================
+ Hits        36685    36875     +190     
- Misses      10472    10714     +242     
+ Partials      144      138       -6
Flag Coverage Δ
cypress 56.03% <100.00%> (+<0.01%) ⬆️
javascript 64.70% <85.71%> (+0.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/components/DatabaseSelector/index.tsx 92.70% <ø> (+1.04%) ⬆️
...et-frontend/src/components/TableSelector/index.tsx 84.92% <ø> (ø)
...src/dashboard/components/dnd/handleScroll/index.ts 73.33% <ø> (ø)
...d/src/explore/components/DatasourcePanel/index.tsx 87.93% <ø> (ø)
...rc/explore/components/DisplayQueryButton/index.jsx 100.00% <ø> (ø)
...re/components/controls/DatasourceControl/index.jsx 86.84% <ø> (ø)
...controls/DndColumnSelectControl/DndSelectLabel.tsx 35.00% <ø> (ø)
...trols/DndColumnSelectControl/components/Option.tsx 50.00% <ø> (ø)
...ents/controls/FilterControl/AdhocFilterControl.jsx 60.00% <ø> (ø)
...Control/AdhocFilterEditPopoverSimpleTabContent.jsx 74.83% <ø> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d54cc6d...6f61a6f. Read the comment docs.

@yardz yardz closed this Mar 31, 2021
@yardz yardz reopened this Mar 31, 2021
yardz and others added 3 commits April 1, 2021 11:19
@yardz @michael-s-molina
Update superset-frontend/src/dashboard/components/SliceHeader/SliceHe…
bb8b027 
…ader.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@yardz @michael-s-molina
Update superset-frontend/src/dashboard/components/SliceHeader/SliceHe…
1607e0f 
…ader.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@yardz @michael-s-molina
Update superset-frontend/src/dashboard/components/SliceHeader/SliceHe…
6f61a6f 
…ader.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
rusackas
rusackas approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit ec3f8d0 into apache:master Apr 9, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@yardz @michael-s-molina
test: SliceHeader (apache#13888)
3c2b032 
* tests for SliceHeader

* Update superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@yardz @michael-s-molina
test: SliceHeader (apache#13888)
fc87c0d 
* tests for SliceHeader

* Update superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina left review comments

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L test:component 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yardz @rusackas @michael-s-molina @mistercrunch @junlincc