Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pie chart not displayed in viz type selection #13987

Merged
merged 1 commit into from Apr 7, 2021

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Apr 7, 2021

SUMMARY

fix can not be displayed chart when some chart support cross filter behavior.

closes: #13962

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

image

after

image

TEST PLAN

tested in my local. would be adding more UT/IT for this case in the future.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #13987 (3e6eb25) into master (ab0f5e3) will increase coverage by 0.58%.
The diff coverage is 85.29%.

❗ Current head 3e6eb25 differs from pull request most recent head bfbc96b. Consider uploading reports for the commit bfbc96b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13987      +/-   ##
==========================================
+ Coverage   78.54%   79.13%   +0.58%     
==========================================
  Files         935      936       +1     
  Lines       47374    47409      +35     
  Branches     5956     5943      -13     
==========================================
+ Hits        37211    37515     +304     
+ Misses      10020     9767     -253     
+ Partials      143      127      -16     
Flag Coverage Δ
cypress 56.04% <75.00%> (+<0.01%) ⬆️
javascript 68.45% <76.47%> (+1.15%) ⬆️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/components/ErrorMessage/types.ts 100.00% <ø> (ø)
...shboard/components/filterscope/FilterFieldItem.jsx 100.00% <ø> (+50.00%) ⬆️
...shboard/components/filterscope/FilterFieldTree.jsx 66.66% <ø> (+22.22%) ⬆️
...hboard/components/filterscope/FilterScopeModal.tsx 75.00% <ø> (ø)
...ard/components/filterscope/FilterScopeSelector.jsx 87.67% <ø> (+85.61%) ⬆️
...shboard/components/filterscope/FilterScopeTree.jsx 70.00% <ø> (+20.00%) ⬆️
...ponents/filterscope/renderFilterFieldTreeNodes.jsx 90.00% <ø> (+90.00%) ⬆️
...ponents/filterscope/renderFilterScopeTreeNodes.jsx 86.66% <ø> (+86.66%) ⬆️
...oard/components/nativeFilters/FilterBar/Header.tsx 87.09% <0.00%> (ø)
...uperset-frontend/src/explore/exploreUtils/index.js 71.06% <ø> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab0f5e3...bfbc96b. Read the comment docs.

@zhaoyongjie zhaoyongjie changed the title fix: Pie chart not displayed in viz fix: Pie chart not displayed in viz type selection Apr 7, 2021
@junlincc
Copy link
Member

junlincc commented Apr 7, 2021

LGTM merge!👍

@junlincc junlincc added rush! Requires immediate attention #bug:blocking! Blocking issues with high priority labels Apr 7, 2021
@zhaoyongjie zhaoyongjie merged commit 56dc74e into apache:master Apr 7, 2021
@Hemant0601
Copy link

@villebro Does this include helm chart fix too?

@junlincc
Copy link
Member

junlincc commented Apr 7, 2021

@villebro Does this include helm chart fix too?

don't think so. what is helm chat btw? @Hemant0601

@zhaoyongjie
Copy link
Member Author

@villebro Does this include helm chart fix too?

Hi, @Hemant0601
what is helm chart? or deploy Superset with helm?

@Hemant0601
Copy link

@zhaoyongjie Yes installtion of superset in kubernetes using helm chart here.

https://github.com/apache/superset/tree/master/helm/superset

@villebro
Copy link
Member

villebro commented Apr 7, 2021

@Hemant0601 yes this PR will also fix the problem on helm.

henryyeh pushed a commit to preset-io/superset that referenced this pull request Apr 7, 2021
john-bodley pushed a commit to airbnb/superset-fork that referenced this pull request Apr 7, 2021
@junlincc junlincc removed #bug:blocking! Blocking issues with high priority rush! Requires immediate attention labels Apr 8, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cross-filter]Pie chart not displayed in visualization type if DASHBOARD_CROSS_FILTERS is not enabled
5 participants