fix: execution log crashes for logs with no uuid #13998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfrag1
changed the title
Codecov Report
@@ Coverage Diff @@
## master #13998 +/- ##
==========================================
+ Coverage 79.02% 79.03% +0.01%
==========================================
Files 936 936
Lines 47408 47408
Branches 5938 5939 +1
==========================================
+ Hits 37465 37471 +6
+ Misses 9817 9811 -6
Partials 126 126
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
🏷️ 2021.13 |
henryyeh
pushed a commit
to preset-io/superset
that referenced
this pull request
Apr 9, 2021
* Fix execution log when no execution id * Use single quotes * Pretty (cherry picked from commit 5dd971e)
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
* Fix execution log when no execution id * Use single quotes * Pretty
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* Fix execution log when no execution id * Use single quotes * Pretty
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
An issue was introduced in #13752 where logs that were created before the
executionIdwas created cause the execution log list view to give the following error:This PR fixes this issue, instead displaying "none" for logs without an
executionId.