Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken port-forward instructions #14039

Merged
merged 1 commit into from Apr 9, 2021
Merged

fix: broken port-forward instructions #14039

merged 1 commit into from Apr 9, 2021

Conversation

caleb15
Copy link
Contributor

@caleb15 caleb15 commented Apr 8, 2021

SUMMARY

The pod listens on port 8088, not port 80. Also if you port-forward from the service then you don't have to bother getting the pod name.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Using correct command:image

TEST PLAN

ADDITIONAL INFORMATION

  • [] Has associated issue:
  • [] Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@caleb15
Fix broken port-forward instructions
89e6694 
The pod listens on port 8088, not port 80. Also if you port-forward from the service then you don't have to bother getting the pod name.
@junlincc junlincc changed the title Fix broken port-forward instructions Fix: broken port-forward instructions Apr 9, 2021
@nytai nytai changed the title Fix: broken port-forward instructions fix: broken port-forward instructions Apr 9, 2021
zhaoyongjie
zhaoyongjie approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the improvements to the documentation.

@amitmiran137 amitmiran137 requested review from craig-rueda and removed request for craig-rueda April 9, 2021 10:16
@amitmiran137 amitmiran137 merged commit 2c96c5b into apache:master Apr 9, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@caleb15
Fix broken port-forward instructions (apache#14039)
3679008 
The pod listens on port 8088, not port 80. Also if you port-forward from the service then you don't have to bother getting the pod name.
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@caleb15
Fix broken port-forward instructions (apache#14039)
a41faed 
The pod listens on port 8088, not port 80. Also if you port-forward from the service then you don't have to bother getting the pod name.
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaoyongjie zhaoyongjie zhaoyongjie approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@caleb15 @zhaoyongjie @mistercrunch @amitmiran137