Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed saved query export #14086

Merged
merged 2 commits into from Apr 13, 2021

Conversation

lyndsiWilliams
Copy link
Member

SUMMARY

My original implementation of the saved query export did not work as designed, it was exporting a dashboard. I have corrected this and saved queries are now exported properly.

TEST PLAN

Tests ensure the proper functionality of a saved query export.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

sting implemented
@pull-request-size pull-request-size bot added size/M and removed size/S labels Apr 12, 2021
@lyndsiWilliams lyndsiWilliams marked this pull request as ready for review April 12, 2021 21:06
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #14086 (c6d41f3) into master (911462a) will increase coverage by 0.02%.
The diff coverage is 77.77%.

❗ Current head c6d41f3 differs from pull request most recent head 9a2d39a. Consider uploading reports for the commit 9a2d39a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14086      +/-   ##
==========================================
+ Coverage   79.44%   79.46%   +0.02%     
==========================================
  Files         939      939              
  Lines       47575    47591      +16     
  Branches     5949     5948       -1     
==========================================
+ Hits        37796    37820      +24     
+ Misses       9657     9649       -8     
  Partials      122      122              
Flag Coverage Δ
cypress 56.01% <0.00%> (-0.01%) ⬇️
javascript 69.32% <20.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/components/ErrorMessage/types.ts 100.00% <ø> (ø)
superset-frontend/src/views/CRUD/utils.tsx 60.60% <0.00%> (-2.56%) ⬇️
superset/tasks/scheduler.py 74.54% <33.33%> (-2.38%) ⬇️
.../src/views/CRUD/data/savedquery/SavedQueryList.tsx 73.72% <100.00%> (ø)
superset/db_engine_specs/postgres.py 96.77% <100.00%> (ø)
superset/errors.py 100.00% <100.00%> (ø)
superset/reports/commands/alert.py 96.47% <100.00%> (+0.04%) ⬆️
superset/reports/commands/execute.py 92.96% <100.00%> (+0.03%) ⬆️
superset/sql_lab.py 81.56% <100.00%> (+1.38%) ⬆️
superset/tasks/async_queries.py 92.06% <100.00%> (+0.99%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 911462a...9a2d39a. Read the comment docs.

@betodealmeida betodealmeida merged commit 6392d41 into apache:master Apr 13, 2021
@lyndsiWilliams lyndsiWilliams deleted the lyndsi/export-sq-fix branch October 15, 2021 01:32
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* Fixed saved query export

* Te
sting implemented
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants