Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Moves Tabs to the components folder #14136

Merged
merged 1 commit into from Apr 27, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Moves Tabs to the components folder.

This work is part of SIP-61

@rusackas @junlincc

TEST PLAN

1 - Execute all tests
2 - All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #14136 (a341ca5) into master (7ff35df) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head a341ca5 differs from pull request most recent head 8f36857. Consider uploading reports for the commit 8f36857 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14136      +/-   ##
==========================================
- Coverage   77.18%   77.14%   -0.04%     
==========================================
  Files         954      954              
  Lines       48134    48140       +6     
  Branches     5985     5987       +2     
==========================================
- Hits        37151    37139      -12     
- Misses      10786    10804      +18     
  Partials      197      197              
Flag Coverage Δ
javascript 72.02% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/SqlLab/components/TabbedSqlEditors.jsx 71.77% <ø> (ø)
superset-frontend/src/components/Tabs/Tabs.tsx 96.87% <ø> (ø)
superset-frontend/src/components/Tabs/index.ts 100.00% <ø> (ø)
...d/src/dashboard/components/gridComponents/Tabs.jsx 87.36% <ø> (ø)
...erset-frontend/src/datasource/DatasourceEditor.jsx 66.38% <ø> (ø)
...ols/FilterControl/AdhocFilterEditPopover/index.jsx 64.81% <ø> (ø)
...ols/MetricControl/AdhocMetricEditPopover/index.jsx 78.78% <ø> (ø)
...tend/src/SqlLab/components/SouthPane/SouthPane.tsx 79.54% <100.00%> (ø)
.../src/dashboard/components/BuilderComponentPane.tsx 100.00% <100.00%> (ø)
...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx 86.36% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ff35df...8f36857. Read the comment docs.

@junlincc junlincc added the sip:61:folder-org Related to the organization of the folders as of SIP 61 label Apr 15, 2021
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs rebase.

Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Needs rebase tho!

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit d0be1ff into apache:master Apr 27, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels sip:61:folder-org Related to the organization of the folders as of SIP 61 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants