Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adds QueryParamProvider to the testing helper #14195

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Adds QueryParamProvider to the testing helper.

Now we can activate the provider with:
render(<Component />, { useQueryParams: true });

@rusackas @junlincc

TEST PLAN

1 - Execute all tests
2- All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@lyndsiWilliams
Copy link
Member

Thank you for adding this, super useful! 🎉

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #14195 (c4bc30b) into master (cab110e) will increase coverage by 0.31%.
The diff coverage is 0.00%.

❗ Current head c4bc30b differs from pull request most recent head 8726c05. Consider uploading reports for the commit 8726c05 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14195      +/-   ##
==========================================
+ Coverage   79.47%   79.79%   +0.31%     
==========================================
  Files         944      944              
  Lines       47914    47916       +2     
  Branches     6067     6067              
==========================================
+ Hits        38082    38233     +151     
+ Misses       9702     9559     -143     
+ Partials      130      124       -6     
Flag Coverage Δ
cypress 56.32% <ø> (+2.73%) ⬆️
javascript 70.25% <ø> (ø)
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/viz.py 55.59% <0.00%> (-0.07%) ⬇️
superset/db_engine_specs/presto.py 84.10% <0.00%> (-5.86%) ⬇️
superset/connectors/sqla/models.py 88.61% <0.00%> (-1.46%) ⬇️
superset/models/core.py 89.10% <0.00%> (-0.28%) ⬇️
...dashboard/components/SliceHeaderControls/index.jsx 79.38% <0.00%> (+1.03%) ⬆️
...rontend/src/visualizations/FilterBox/FilterBox.jsx 73.58% <0.00%> (+1.25%) ⬆️
...ntend/src/explore/components/ExploreChartPanel.jsx 82.60% <0.00%> (+1.44%) ⬆️
...set-frontend/src/dashboard/util/getDropPosition.js 92.42% <0.00%> (+1.51%) ⬆️
...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx 95.00% <0.00%> (+1.66%) ⬆️
superset-frontend/src/views/routes.tsx 56.81% <0.00%> (+2.27%) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cab110e...8726c05. Read the comment docs.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@junlincc junlincc added the sip:61:folder-org Related to the organization of the folders as of SIP 61 label May 5, 2021
@rusackas rusackas merged commit fa510df into apache:master May 6, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels sip:61:folder-org Related to the organization of the folders as of SIP 61 size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants