Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cross-filters): Fix missed metadata #14220

Merged
merged 3 commits into from
Apr 18, 2021
Merged

fix(cross-filters): Fix missed metadata #14220

merged 3 commits into from
Apr 18, 2021

Conversation

simcha90
Copy link
Contributor

@simcha90 simcha90 commented Apr 18, 2021 •
edited
Loading

SUMMARY

When dashboardInfo -> metadata field missed in redux
It crashes for new dashboards with FF FeatureFlag.DASHBOARD_CROSS_FILTERS enabled

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro villebro merged commit c01f810 into apache:master Apr 18, 2021
amitmiran137 pushed a commit to simcha90/incubator-superset that referenced this pull request Apr 19, 2021
Merge branch 'master' into feat/native_groupby
3c405b5 
* master:
  fix: Use utils.json_iso_dttm_ser to dump jsons when async query execution (apache#13830)
  feat: TrinoEngineSpec.adjust_database_uri (apache#14122)
  chore: bump package.json (apache#14222)
  Add superset helm repository (apache#14223)
  fix(cross-filters): Fix missed metadata (apache#14220)
@junlincc junlincc added the dashboard:cross-filters Related to the Dashboard cross filters label Apr 27, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@simcha90
fix(cross-filters): Fix missed metadata (apache#14220)
62bd556 
* fix:fix get permission function

* fix: fix missed metadata case
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

@amitmiran137 amitmiran137 amitmiran137 approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:cross-filters Related to the Dashboard cross filters size/XS v1.2 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@simcha90 @villebro @amitmiran137 @mistercrunch @junlincc