fix(native-filters): merge_extra_form_data extras processing

[villebro]

SUMMARY

The utility function that merges extra_form_data into the main form_data processed extras incorrectly. This fixes the error and adds a test that would have caught it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

CI + new tests

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #14244 (6119d8e) into master (9d67b46) will decrease coverage by 0.22%.
The diff coverage is 77.27%.

❗ Current head 6119d8e differs from pull request most recent head 354014b. Consider uploading reports for the commit 354014b to get more accurate results

@@            Coverage Diff             @@
##           master   #14244      +/-   ##
==========================================
- Coverage   76.11%   75.89%   -0.23%     
==========================================
  Files         945      945              
  Lines       47947    47947              
  Branches     5950     5950              
==========================================
- Hits        36495    36388     -107     
- Misses      11246    11353     +107     
  Partials      206      206              

Flag	Coverage Δ
hive	?
mysql	80.67% <ø> (ø)
postgres	80.71% <ø> (?)
presto	?
python	80.79% <ø> (-0.42%)	⬇️
sqlite	80.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...nativeFilters/FilterBar/FilterSets/EditSection.tsx	80.00% <ø> (ø)
...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx	91.42% <ø> (ø)
...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx	95.23% <ø> (ø)
...omponents/nativeFilters/FilterBar/Header/index.tsx	90.32% <ø> (ø)
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx	83.72% <ø> (ø)
...mponents/nativeFilters/FiltersConfigModal/utils.ts	34.24% <ø> (ø)
...nts/controls/DateFilterControl/DateFilterLabel.tsx	19.82% <0.00%> (ø)
superset-frontend/src/utils/common.js	87.71% <ø> (ø)
...nents/nativeFilters/FilterBar/FilterSets/index.tsx	46.93% <50.00%> (ø)
superset-frontend/src/components/Icon/index.tsx	100.00% <100.00%> (ø)
... and 29 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d67b46...354014b. Read the comment docs.

[villebro]

For legacy plugins (viz.py), these have to be mapped into the main form_data, as they are later mapped to extras where they should ultimately go:

superset/superset/viz.py

Lines 363 to 370 in 6119d8e

	extras = {
	"druid_time_origin": form_data.get("druid_time_origin", ""),
	"having": form_data.get("having", ""),
	"having_druid": form_data.get("having_filters", []),
	"time_grain_sqla": form_data.get("time_grain_sqla"),
	"time_range_endpoints": form_data.get("time_range_endpoints"),
	"where": form_data.get("where", ""),
	}