Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update SIP template #14278

Merged
merged 3 commits into from
Jun 28, 2021
Merged

docs: Update SIP template #14278

merged 3 commits into from
Jun 28, 2021

Conversation

john-bodley
Copy link
Member

SUMMARY

Adding documentation regarding numbering of SIPs.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #14278 (792929f) into master (70cfb77) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #14278    +/-   ##
========================================
  Coverage   77.01%   77.01%            
========================================
  Files         954      954            
  Lines       48066    48066            
  Branches     5973     5547   -426     
========================================
  Hits        37016    37016            
- Misses      10848    10853     +5     
+ Partials      202      197     -5     
Flag Coverage Δ
hive 80.44% <ø> (ø)
javascript 72.10% <ø> (ø)
mysql 80.72% <ø> (ø)
postgres 80.76% <ø> (+0.01%) ⬆️
presto 80.45% <ø> (ø)
python 81.29% <ø> (ø)
sqlite 80.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/SqlLab/components/RunQueryActionButton.tsx 64.28% <0.00%> (ø)
...d/src/filters/components/GroupBy/transformProps.ts 33.33% <0.00%> (ø)
...src/filters/components/TimeGrain/transformProps.ts 33.33% <0.00%> (ø)
...rc/filters/components/TimeColumn/transformProps.ts 33.33% <0.00%> (ø)
...ts/nativeFilters/FilterBar/FilterControls/state.ts 80.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70cfb77...792929f. Read the comment docs.

@john-bodley john-bodley changed the title [SIP] Update SIP template docs: Update SIP template Apr 21, 2021
.github/ISSUE_TEMPLATE/sip.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/sip.md Show resolved Hide resolved
@stale
Copy link

stale bot commented Jun 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Jun 26, 2021
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
@stale stale bot removed the inactive Inactive for >= 30 days label Jun 27, 2021
@amitmiran137 amitmiran137 merged commit f53b2c6 into master Jun 28, 2021
@amitmiran137 amitmiran137 deleted the john-bodley--sip-template branch June 28, 2021 04:28
mvoitko pushed a commit to mvoitko/superset that referenced this pull request Jun 28, 2021
* [SIP] Update SIP template

* Update sip.md

* Update .github/ISSUE_TEMPLATE/sip.md

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>

Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com>
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* [SIP] Update SIP template

* Update sip.md

* Update .github/ISSUE_TEMPLATE/sip.md

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>

Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com>
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* [SIP] Update SIP template

* Update sip.md

* Update .github/ISSUE_TEMPLATE/sip.md

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>

Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com>
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Feb 19, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* [SIP] Update SIP template

* Update sip.md

* Update .github/ISSUE_TEMPLATE/sip.md

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>

Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com>
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants