Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve Japanese translation #14339

Merged
merged 1 commit into from Apr 27, 2021
Merged

Conversation

bungoume
Copy link
Contributor

SUMMARY

Improve Japanese translation.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! a cursory glance with my hobbyist Japanese skills indicates this is good, but if anyone else from the community knows Japanese, a secondary review would be appreciated

@etr2460
Copy link
Member

etr2460 commented Apr 26, 2021

@bungoume could you run pre-commit locally to fix this CI check?
image

@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #14339 (3184c54) into master (3e8bf96) will decrease coverage by 0.27%.
The diff coverage is 44.44%.

❗ Current head 3184c54 differs from pull request most recent head 715d636. Consider uploading reports for the commit 715d636 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14339      +/-   ##
==========================================
- Coverage   77.17%   76.90%   -0.28%     
==========================================
  Files         954      954              
  Lines       48134    48141       +7     
  Branches     5985     5987       +2     
==========================================
- Hits        37149    37022     -127     
- Misses      10788    10922     +134     
  Partials      197      197              
Flag Coverage Δ
hive ?
mysql 81.04% <36.84%> (-0.01%) ⬇️
postgres 81.07% <36.84%> (+0.01%) ⬆️
presto ?
python 81.15% <36.84%> (-0.46%) ⬇️
sqlite 80.68% <36.84%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 91.12% <ø> (ø)
superset/db_engine_specs/base.py 87.68% <0.00%> (-0.44%) ⬇️
superset/security/manager.py 91.48% <ø> (ø)
superset/views/base_api.py 98.28% <ø> (ø)
superset/views/base_schemas.py 0.00% <0.00%> (ø)
superset/views/sql_lab.py 60.68% <0.00%> (ø)
superset/views/core.py 75.65% <14.28%> (-0.06%) ⬇️
superset/jinja_context.py 87.57% <33.33%> (ø)
...src/dashboard/components/FiltersBadge/selectors.ts 76.92% <50.00%> (-1.65%) ⬇️
superset/charts/api.py 81.81% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e8bf96...715d636. Read the comment docs.

@etr2460 etr2460 merged commit d645312 into apache:master Apr 27, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants