Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky test for alerts and reports #14347

Merged
merged 5 commits into from Apr 26, 2021

Conversation

dpgaspar
Copy link
Member

SUMMARY

Fixes a flaky command test for alerts and reports. By not executing an ordered query the assert assumptions could potencialy fail

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #14347 (5f829bd) into master (b8356a6) will decrease coverage by 0.11%.
The diff coverage is 50.00%.

❗ Current head 5f829bd differs from pull request most recent head 442205e. Consider uploading reports for the commit 442205e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14347      +/-   ##
==========================================
- Coverage   77.15%   77.04%   -0.12%     
==========================================
  Files         954      954              
  Lines       48134    48134              
  Branches     5985     5985              
==========================================
- Hits        37140    37083      -57     
- Misses      10797    10854      +57     
  Partials      197      197              
Flag Coverage Δ
hive ?
mysql 81.04% <ø> (ø)
postgres 81.08% <ø> (?)
presto 80.78% <ø> (ø)
python 81.35% <ø> (-0.23%) ⬇️
sqlite 80.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/dashboard/components/FiltersBadge/selectors.ts 78.57% <50.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 70.80% <0.00%> (-16.80%) ⬇️
superset/connectors/sqla/models.py 89.83% <0.00%> (-0.25%) ⬇️
superset/utils/core.py 88.65% <0.00%> (-0.13%) ⬇️
superset/views/base_api.py 98.28% <0.00%> (+0.42%) ⬆️
superset/db_engine_specs/postgres.py 96.90% <0.00%> (+1.03%) ⬆️
superset/sql_validators/postgres.py 100.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8356a6...442205e. Read the comment docs.

@dpgaspar dpgaspar requested a review from villebro April 26, 2021 13:09
@dpgaspar dpgaspar merged commit 45e209d into apache:master Apr 26, 2021
@dpgaspar dpgaspar deleted the fix/reports-cmd-test branch April 26, 2021 17:56
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants